Page MenuHomePhabricator

Store Phriction max version on Document, improve editing rules for editing documents with drafts
ClosedPublic

Authored by epriestley on Aug 30 2018, 5:09 PM.
Tags
None
Referenced Files
F13205530: D19625.diff
Wed, May 15, 2:03 AM
F13189382: D19625.diff
Sat, May 11, 5:54 AM
Unknown Object (File)
Tue, May 7, 9:38 AM
Unknown Object (File)
Sat, May 4, 8:42 AM
Unknown Object (File)
Fri, May 3, 9:15 AM
Unknown Object (File)
Thu, Apr 25, 12:27 PM
Unknown Object (File)
Mon, Apr 22, 6:47 PM
Unknown Object (File)
Apr 19 2024, 7:54 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13077. We need to know the maximum version of a document in several cases, so denormalize it onto the Document object.

Then clean up some behaviors where we edit a document with, e.g., 7 versions but version 5 is currently published. For now, we: edit starting with version 7, save as version 8, and immediately publish the new version.

Test Plan
  • Ran migration.
  • Edited a draft page without hitting any weird version errors.
  • Checked database for sensible maxVersion values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 30 2018, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.