Page MenuHomePhabricator

Store Phriction max version on Document, improve editing rules for editing documents with drafts
ClosedPublic

Authored by epriestley on Aug 30 2018, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 9:43 AM
Unknown Object (File)
Mon, Mar 4, 10:37 PM
Unknown Object (File)
Feb 7 2024, 8:20 AM
Unknown Object (File)
Jan 12 2024, 10:47 PM
Unknown Object (File)
Dec 26 2023, 10:12 AM
Unknown Object (File)
Dec 22 2023, 12:17 AM
Unknown Object (File)
Dec 10 2023, 1:06 AM
Unknown Object (File)
Dec 4 2023, 9:58 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13077. We need to know the maximum version of a document in several cases, so denormalize it onto the Document object.

Then clean up some behaviors where we edit a document with, e.g., 7 versions but version 5 is currently published. For now, we: edit starting with version 7, save as version 8, and immediately publish the new version.

Test Plan
  • Ran migration.
  • Edited a draft page without hitting any weird version errors.
  • Checked database for sensible maxVersion values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 30 2018, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.