Page MenuHomePhabricator

Store Phriction max version on Document, improve editing rules for editing documents with drafts
ClosedPublic

Authored by epriestley on Aug 30 2018, 5:09 PM.
Tags
None
Referenced Files
F20588281: D19625.diff
Fri, Jun 19, 8:52 PM
Unknown Object (File)
Tue, Jun 9, 5:18 PM
Unknown Object (File)
Fri, Jun 5, 12:41 AM
Unknown Object (File)
Apr 11 2026, 3:24 PM
Unknown Object (File)
Apr 4 2026, 2:40 AM
Unknown Object (File)
Mar 23 2026, 7:50 AM
Unknown Object (File)
Mar 23 2026, 7:50 AM
Unknown Object (File)
Mar 4 2026, 5:06 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13077. We need to know the maximum version of a document in several cases, so denormalize it onto the Document object.

Then clean up some behaviors where we edit a document with, e.g., 7 versions but version 5 is currently published. For now, we: edit starting with version 7, save as version 8, and immediately publish the new version.

Test Plan
  • Ran migration.
  • Edited a draft page without hitting any weird version errors.
  • Checked database for sensible maxVersion values.

Diff Detail

Repository
rP Phabricator
Branch
phriction9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20716
Build 28160: Run Core Tests
Build 28159: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 30 2018, 5:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.