Page MenuHomePhabricator
Differential D19610

Make some remarkup handling in Config cleaner, fixing {{other.option} links
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 4:51 PM.
Tags
None
Referenced Files
F15196995: D19610.diff
Sat, Feb 22, 8:14 PM
Unknown Object (File)
Sat, Feb 15, 3:46 AM
Unknown Object (File)
Sun, Feb 9, 6:23 AM
Unknown Object (File)
Sun, Feb 9, 6:23 AM
Unknown Object (File)
Sun, Feb 9, 6:22 AM
Unknown Object (File)
Tue, Jan 28, 4:07 AM
Unknown Object (File)
Sat, Jan 25, 8:00 AM
Unknown Object (File)
Sat, Jan 25, 2:04 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13189: Plans: 2018 Week 35 Bonus Content
Commits
rPb87a809b0bfe: Make some remarkup handling in Config cleaner, fixing {{other.option} links
Summary

Depends on D19609. Ref T13189. At some point, we switched from RemarkupEngine to RemarkupView and lost this piece of hack-magic.

Restore the hack-magic. It's still hack-magic instead of a real rule, but things are at least cleaner than they were before.

Test Plan

Viewed auth.require-approval, etc. Saw references to other config options linked properly.

Diff Detail

Repository
rP Phabricator
Branch
issues2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/config/option/PhabricatorConfigOption.php:212XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 20685
Build 28114: Run Core Tests
Build 28113: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
26 lines
option/
43 lines

Diff 46880

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/option/PhabricatorConfigOption.php

Loading...
Phabricator · Built by Phacility