Page MenuHomePhabricator
Differential D19610

Make some remarkup handling in Config cleaner, fixing {{other.option} links
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 4:51 PM.
Tags
None
Referenced Files
F19769153: D19610.id46880.diff
Thu, Feb 19, 7:35 PM
F19715031: D19610.diff
Thu, Feb 12, 3:31 AM
F19530765: D19610.id46880.diff
Jan 20 2026, 12:07 AM
F19303631: D19610.id46880.diff
Dec 24 2025, 3:32 AM
F19103561: D19610.diff
Dec 5 2025, 11:14 AM
F19017227: D19610.id.diff
Nov 23 2025, 7:05 AM
F18851802: D19610.id.diff
Oct 31 2025, 4:21 AM
F18851576: D19610.id.diff
Oct 31 2025, 2:18 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13189: Plans: 2018 Week 35 Bonus Content
Commits
rPb87a809b0bfe: Make some remarkup handling in Config cleaner, fixing {{other.option} links
Summary

Depends on D19609. Ref T13189. At some point, we switched from RemarkupEngine to RemarkupView and lost this piece of hack-magic.

Restore the hack-magic. It's still hack-magic instead of a real rule, but things are at least cleaner than they were before.

Test Plan

Viewed auth.require-approval, etc. Saw references to other config options linked properly.

Diff Detail

Repository
rP Phabricator
Branch
issues2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/config/option/PhabricatorConfigOption.php:212XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 20685
Build 28114: Run Core Tests
Build 28113: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
26 lines
option/
43 lines

Diff 46880

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/option/PhabricatorConfigOption.php

Loading...
Phabricator · Built by Phacility