Page MenuHomePhabricator
Differential D19610

Make some remarkup handling in Config cleaner, fixing {{other.option} links
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 4:51 PM.
Tags
None
Referenced Files
F18346613: D19610.diff
Tue, Aug 26, 2:00 PM
F18093193: D19610.id46880.diff
Thu, Aug 7, 4:16 PM
F18088198: D19610.id.diff
Wed, Aug 6, 7:15 AM
F18083849: D19610.diff
Tue, Aug 5, 11:48 AM
Unknown Object (File)
Jul 2 2025, 6:09 AM
Unknown Object (File)
May 30 2025, 3:50 PM
Unknown Object (File)
May 28 2025, 12:22 PM
Unknown Object (File)
May 27 2025, 11:29 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13189: Plans: 2018 Week 35 Bonus Content
Commits
rPb87a809b0bfe: Make some remarkup handling in Config cleaner, fixing {{other.option} links
Summary

Depends on D19609. Ref T13189. At some point, we switched from RemarkupEngine to RemarkupView and lost this piece of hack-magic.

Restore the hack-magic. It's still hack-magic instead of a real rule, but things are at least cleaner than they were before.

Test Plan

Viewed auth.require-approval, etc. Saw references to other config options linked properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
26 lines
option/
43 lines

Diff 46882

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/option/PhabricatorConfigOption.php

Loading...
Phabricator · Built by Phacility