Paths

Table of Contentst

Differential D19610

Make some remarkup handling in Config cleaner, fixing {{other.option} links
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 4:51 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13189: Plans: 2018 Week 35 Bonus Content

Commits

rPb87a809b0bfe: Make some remarkup handling in Config cleaner, fixing {{other.option} links

Summary

Depends on D19609. Ref T13189. At some point, we switched from RemarkupEngine to RemarkupView and lost this piece of hack-magic.

Restore the hack-magic. It's still hack-magic instead of a real rule, but things are at least cleaner than they were before.

Test Plan

Viewed auth.require-approval, etc. Saw references to other config options linked properly.

Diff Detail

Repository

rP Phabricator

Branch

issues2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/config/option/PhabricatorConfigOption.php:212	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 20685
Build 28114: Run Core Tests
Build 28113: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 27 2018, 4:51 PM

Harbormaster completed remote builds in B20685: Diff 46880.Aug 27 2018, 4:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2018, 4:53 PM

epriestley requested review of this revision.

Closed by commit rPb87a809b0bfe: Make some remarkup handling in Config cleaner, fixing {{other.option} links (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19612: Remove another old remarkup engine callsite in Config.Aug 27 2018, 5:53 PM

epriestley mentioned this in rPee823982a46b: Remove another old remarkup engine callsite in Config.Aug 27 2018, 6:10 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

config/

controller/

PhabricatorConfigEditController.php

26 lines

option/

PhabricatorConfigOption.php

43 lines

Diff 46880

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/controller/PhabricatorConfigEditController.php

View Options

src/applications/config/option/PhabricatorConfigOption.php

Make some remarkup handling in Config cleaner, fixing {{other.option} linksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46880

src/__phutil_library_map__.php

src/applications/config/controller/PhabricatorConfigEditController.php

src/applications/config/option/PhabricatorConfigOption.php

Make some remarkup handling in Config cleaner, fixing {{other.option} links
ClosedPublic
Actions

Revision Contents
Changeset List