Differential D19604

Replace "Disable User" web UI flow with transactions
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 1:35 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13189: Plans: 2018 Week 35 Bonus Content

Commits

rP2f7b10c023b9: Replace "Disable User" web UI flow with transactions

Summary

Ref T13189. See PHI642. Upgrades the "Disable" action in the web UI to be transaction-based.

This technically breaks things a little (you can't disable non-bot users, since they now require CAN_EDIT and you won't have it) but an upcoming change will fix the permissions issue.

Test Plan

Disabled and enabled a (bot) user from the web UI.

Diff Detail

Repository

rP Phabricator

Branch

disable1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20674
Build 28097: Run Core Tests
Build 28096: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 27 2018, 1:35 PM

Harbormaster completed remote builds in B20674: Diff 46869.Aug 27 2018, 1:36 PM

epriestley requested review of this revision.Aug 27 2018, 1:36 PM

epriestley added a child revision: D19605: Deprecate "user.enable" and "user.disable" API methods, redefine them in terms of "user.edit".Aug 27 2018, 1:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2018, 3:00 PM

Closed by commit rP2f7b10c023b9: Replace "Disable User" web UI flow with transactions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleDisableController.php

13 lines

Diff 46869

View Options

src/applications/people/controller/PhabricatorPeopleDisableController.php

Replace "Disable User" web UI flow with transactionsClosedPublicActions