Page MenuHomePhabricator

Make the ArcanistBundle algorithm do what "diff -u" does when hunks are arguably mergeable
ClosedPublic

Authored by epriestley on Aug 24 2018, 5:58 PM.
Tags
None
Referenced Files
F15385319: D19603.diff
Fri, Mar 14, 10:14 PM
F15381715: D19603.id46867.diff
Fri, Mar 14, 9:02 AM
F15378406: D19603.diff
Thu, Mar 13, 2:16 PM
F15358005: D19603.id46865.diff
Tue, Mar 11, 7:08 AM
F15353206: D19603.diff
Mon, Mar 10, 8:21 PM
F15304148: D19603.id46865.diff
Thu, Mar 6, 1:26 AM
Unknown Object (File)
Mon, Mar 3, 4:56 AM
Unknown Object (File)
Thu, Feb 27, 2:06 PM
Subscribers
None

Details

Summary

Ref T13187. See PHI838. If two hunks are separated by 7 lines of context, we can render them as either:

+ Hunk A
  Context 1
  Context 2
  Context 3
  Context 4
  Context 5
  Context 6
  Context 7
+ Hunk B

...or:

+ Hunk A
  Context 1
  Context 2
  Context 3
@@ +1,2 -3,4 @@
  Context 5
  Context 6
  Context 7
+ Hunk B

Since we get the same number of output lines either way and the first one is more human-readable, we picked that one.

However, diff -u does the second one. Since human-readability is probably less important than compatibility, change the behavior to be more similar to diff -u.

Test Plan

Added unit tests for the edge cases with default parameters (6 context lines, 7 context lines) and made them pass.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:58 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.