Page MenuHomePhabricator

Make the ArcanistBundle algorithm do what "diff -u" does when hunks are arguably mergeable
ClosedPublic

Authored by epriestley on Aug 24 2018, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 26, 4:38 PM
Unknown Object (File)
Fri, Jun 19, 7:54 PM
Unknown Object (File)
Fri, Jun 19, 7:54 PM
Unknown Object (File)
Wed, Jun 10, 10:38 PM
Unknown Object (File)
Mar 15 2026, 1:50 PM
Unknown Object (File)
Mar 4 2026, 12:41 PM
Unknown Object (File)
Feb 7 2026, 3:25 AM
Unknown Object (File)
Dec 23 2025, 3:09 AM
Subscribers
None

Details

Summary

Ref T13187. See PHI838. If two hunks are separated by 7 lines of context, we can render them as either:

+ Hunk A
  Context 1
  Context 2
  Context 3
  Context 4
  Context 5
  Context 6
  Context 7
+ Hunk B

...or:

+ Hunk A
  Context 1
  Context 2
  Context 3
@@ +1,2 -3,4 @@
  Context 5
  Context 6
  Context 7
+ Hunk B

Since we get the same number of output lines either way and the first one is more human-readable, we picked that one.

However, diff -u does the second one. Since human-readability is probably less important than compatibility, change the behavior to be more similar to diff -u.

Test Plan

Added unit tests for the edge cases with default parameters (6 context lines, 7 context lines) and made them pass.

Diff Detail

Repository
rARC Arcanist
Branch
merge1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20666
Build 28088: Run Core Tests
Build 28087: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:58 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.