Page MenuHomePhabricator

Support Mercurial "protocaps" wire command
ClosedPublic

Authored by epriestley on Aug 23 2018, 10:03 PM.
Tags
None
Referenced Files
F14055018: D19596.diff
Sat, Nov 16, 7:27 AM
F14041440: D19596.diff
Mon, Nov 11, 6:40 PM
F14036022: D19596.id46851.diff
Sun, Nov 10, 8:16 AM
F14026948: D19596.diff
Fri, Nov 8, 3:57 AM
F14014576: D19596.id46851.diff
Sun, Nov 3, 6:12 AM
F14012649: D19596.diff
Fri, Nov 1, 2:55 PM
F13963850: D19596.diff
Oct 15 2024, 6:14 PM
Unknown Object (File)
Oct 9 2024, 9:56 AM
Subscribers
None

Details

Summary

Ref T13187. See PHI834. Mercurial has somewhat-recently (changeset is from Jan 2018) introduced a new "protocaps" command, that appears in Mercurial 4.7 and possibly before then.

We must explicitly enumerate all protocol commands because you can't decode the protocol without knowing how many arguments the command expects, so enumerate it.

(Also fix an issue where the related error message had an extra apostrophe.)

Test Plan
  • Ran hg clone ... with client and server on Mercurial 4.7.
  • Before: fatal on unknown "protocaps" command.
  • Midway: better typography in error message.
  • After: clean clone.

Diff Detail

Repository
rP Phabricator
Branch
protocaps
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20652
Build 28066: Run Core Tests
Build 28065: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2018, 10:04 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.