Fix truncation in "bin/storage probe" of tables larger than 100GB
ClosedPublic
Actions

Authored by epriestley on Aug 8 2018, 4:29 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rP201f29fbf4ab: Fix truncation in "bin/storage probe" of tables larger than 100GB

Summary

Ref T13164. PHI805 incidentally includes some bin/storage probe output for 100GB+ tables which renders wrong.

We have the tools to render it properly, so stop doing this manually and let ConsoleTable figure out the alignment.

Test Plan

Faked very large table sizes, ran bin/storage probe:

Screen Shot 2018-08-08 at 9.24.36 AM.png (982×1 px, 254 KB)

(Then, un-faked the very large table sizes and ran it again, got sensible output.)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 8 2018, 4:29 PM

Harbormaster completed remote builds in B20579: Diff 46777.Aug 8 2018, 4:30 PM

epriestley requested review of this revision.Aug 8 2018, 4:30 PM

amckinley accepted this revision.Aug 8 2018, 4:42 PM

This revision is now accepted and ready to land.Aug 8 2018, 4:42 PM

Closed by commit rP201f29fbf4ab: Fix truncation in "bin/storage probe" of tables larger than 100GB (authored by epriestley). · Explain WhyAug 8 2018, 4:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementProbeWorkflow.php

16 lines

Diff 46778

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php

Fix truncation in "bin/storage probe" of tables larger than 100GBClosedPublicActions