Page MenuHomePhabricator

Stop indexing the chunk data objects for large Files stored in multiple chunks
ClosedPublic

Authored by epriestley on Aug 3 2018, 9:26 PM.
Tags
None
Referenced Files
F15395978: D19563.diff
Sun, Mar 16, 11:01 AM
F15389334: D19563.id.diff
Sat, Mar 15, 5:07 AM
F15379716: D19563.id.diff
Thu, Mar 13, 10:58 PM
Unknown Object (File)
Sun, Mar 2, 11:34 AM
Unknown Object (File)
Feb 9 2025, 6:15 AM
Unknown Object (File)
Feb 9 2025, 6:15 AM
Unknown Object (File)
Feb 9 2025, 6:15 AM
Unknown Object (File)
Jan 30 2025, 9:02 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI766. Currently, when file data is stored in small chunks, we submit each chunk to the indexing engine.

However, chunks are never surfaced directly and can never be found via any search/query, so this work is pointless. Just skip it.

(It would be nice to do this a little more formally on IndexableInterface or similar as isThisAnIndexableObject(), but we'd have to add like a million empty "yes, index this always" methods to do that, and it seems unlikely that we'll end up with too many other objects like these.)

Test Plan
  • Ran bin/harbormaster rebuild-log --id ... --force before and after change, saw about 200 fewer queries after the change.
  • Uploaded a uniquely named file and searched for it to make sure I didn't break that.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable