Page MenuHomePhabricator

Stop indexing the chunk data objects for large Files stored in multiple chunks
ClosedPublic

Authored by epriestley on Aug 3 2018, 9:26 PM.
Tags
None
Referenced Files
F15484820: D19563.diff
Wed, Apr 9, 8:19 PM
F15461674: D19563.id46767.diff
Tue, Apr 1, 10:15 AM
F15457233: D19563.diff
Sun, Mar 30, 3:06 PM
F15430791: D19563.diff
Mar 24 2025, 8:59 AM
F15424030: D19563.diff
Mar 22 2025, 7:56 PM
F15395978: D19563.diff
Mar 16 2025, 11:01 AM
F15389334: D19563.id.diff
Mar 15 2025, 5:07 AM
F15379716: D19563.id.diff
Mar 13 2025, 10:58 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI766. Currently, when file data is stored in small chunks, we submit each chunk to the indexing engine.

However, chunks are never surfaced directly and can never be found via any search/query, so this work is pointless. Just skip it.

(It would be nice to do this a little more formally on IndexableInterface or similar as isThisAnIndexableObject(), but we'd have to add like a million empty "yes, index this always" methods to do that, and it seems unlikely that we'll end up with too many other objects like these.)

Test Plan
  • Ran bin/harbormaster rebuild-log --id ... --force before and after change, saw about 200 fewer queries after the change.
  • Uploaded a uniquely named file and searched for it to make sure I didn't break that.

Diff Detail

Repository
rP Phabricator
Branch
chunkindex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20566
Build 27937: Run Core Tests
Build 27936: arc lint + arc unit