Support querying Herald rules by monogram in typeahead datsources
ClosedPublic
Actions

Authored by epriestley on Aug 1 2018, 7:46 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rPe72296f9274d: Support querying Herald rules by monogram in typeahead datsources

Summary

Depends on D19556. See PHI765. Ref T13164. Currently, if you type H1 in this datasource, it isn't smart enough to pull up the right object.

Add support for querying by monogram. This is similar to existing support in Owners packages, etc.

Test Plan

Typed H1 in the new push log filter, got the right object as a result in the typeahead.

Diff Detail

Repository

rP Phabricator

Branch

push3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20553
Build 27918: Run Core Tests
Build 27917: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 1 2018, 7:46 PM

Harbormaster completed remote builds in B20553: Diff 46754.Aug 1 2018, 7:48 PM

epriestley requested review of this revision.Aug 1 2018, 7:48 PM

amckinley accepted this revision.Aug 1 2018, 10:54 PM

This revision is now accepted and ready to land.Aug 1 2018, 10:54 PM

Closed by commit rPe72296f9274d: Support querying Herald rules by monogram in typeahead datsources (authored by epriestley). · Explain WhyAug 2 2018, 12:52 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.Aug 13 2018, 4:53 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

typeahead/

HeraldRuleDatasource.php

16 lines

Diff 46754

View Options

src/applications/herald/typeahead/HeraldRuleDatasource.php

Support querying Herald rules by monogram in typeahead datsourcesClosedPublicActions