Page MenuHomePhabricator

When a Herald rule blocks a push, show which rule fired in the push log UI
ClosedPublic

Authored by epriestley on Aug 1 2018, 3:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 8:25 AM
Unknown Object (File)
Wed, Jan 29, 2:38 PM
Unknown Object (File)
Tue, Jan 28, 3:57 AM
Unknown Object (File)
Sat, Jan 25, 1:47 AM
Unknown Object (File)
Sat, Jan 25, 1:47 AM
Unknown Object (File)
Sat, Jan 25, 1:47 AM
Unknown Object (File)
Tue, Jan 21, 1:02 PM
Unknown Object (File)
Tue, Jan 21, 9:35 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI765. We currently show "Rejected: Herald" in the push log UI, but don't show which rule rejected a push.

We store this data, and it's potentially useful: either for hunting down a particular issue, or for getting a general sense of how often a reject rule is triggering (maybe because you want to tune how aggressive it is).

Show this data in the web UI, and include it in the data export payload.

Test Plan
  • Pushed to a hosted repository so that I got blocked by a Herald rule.
  • Viewed the push logs in the web UI, now saw which rule triggered things.
  • Exported logs to CSV, saw Herald rule PHIDs in the data.

Screen Shot 2018-08-01 at 8.38.59 AM.png (1×1 px, 173 KB)

Diff Detail

Repository
rP Phabricator
Branch
push1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20551
Build 27914: Run Core Tests
Build 27913: arc lint + arc unit