Make re-running `rebuild-identities` a bit faster and add a little progress information
ClosedPublic
Actions

Authored by epriestley on Jun 12 2018, 2:08 PM.

Details

Reviewers

Maniphest Tasks

T12164: Put an indirection layer between author/committer strings and user accounts
T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rP38557b96c27e: (stable) Make re-running `rebuild-identities` a bit faster and add a little…
rP1459fb303769: Make re-running `rebuild-identities` a bit faster and add a little progress…

Summary

Ref T13151. Ref T12164. Two small tweaks:

If we aren't actually going to change anything, just skip the writes. This makes re-running/resuming a lot faster (~20x, locally).
Print when we touch a commit so there's some kind of visible status.

This is just a small quality-of-life tweak that I wrote anyway while investigating T13152, and will make finishing off db024, db025 and db010 manually a little easier.

Test Plan

Set authorIdentityPHID + committerIdentityPHID to NULL.
Ran rebuild-identities, saw status information.
Ran rebuild-identiites again, saw it go faster with status information.

Diff Detail

Repository

rP Phabricator

Branch

faster1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20406
Build 27710: Run Core Tests
Build 27709: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 12 2018, 2:08 PM

Harbormaster completed remote builds in B20406: Diff 46600.Jun 12 2018, 2:09 PM

epriestley requested review of this revision.Jun 12 2018, 2:09 PM

amckinley accepted this revision.Jun 12 2018, 7:18 PM

amckinley added inline comments.

src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php
36–38	I was thinking we could speed this up instead by searching for commits without identities, but presumably users might want to actually "rebuild all identities", as advertised...
66–73	I'm convinced that reusing `$identity_phid` here is ok, but it took me a second.
81–83	...and presumably doing all these writes is the expensive part of the operation anyway.

This revision is now accepted and ready to land.Jun 12 2018, 7:18 PM

Closed by commit rP1459fb303769: Make re-running `rebuild-identities` a bit faster and add a little progress… (authored by epriestley). · Explain WhyJun 12 2018, 8:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12164: Put an indirection layer between author/committer strings and user accounts.Jun 12 2018, 9:07 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

management/

PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php

48 lines

Diff 46600

View Options

src/applications/repository/management/PhabricatorRepositoryManagementRebuildIdentitiesWorkflow.php

Make re-running `rebuild-identities` a bit faster and add a little progress informationClosedPublicActions