Differential D19474

Fix an issue where scrolling down, then up, then down fails to show changeset header in Differential
ClosedPublic
Actions

Authored by epriestley on Jun 7 2018, 4:45 PM.

Tags

None

Referenced Files

	F15396828: D19474.diff
	Sun, Mar 16, 4:31 PM

	F15344354: D19474.diff
	Mon, Mar 10, 4:01 AM

	Unknown Object (File)
	Sun, Mar 2, 6:25 PM

	Unknown Object (File)
	Feb 4 2025, 5:55 PM

	Unknown Object (File)
	Jan 28 2025, 5:55 PM

	Unknown Object (File)
	Jan 28 2025, 3:51 AM

	Unknown Object (File)
	Jan 27 2025, 4:03 PM

	Unknown Object (File)
	Jan 4 2025, 12:40 AM

Subscribers

None

Details

Reviewers

amckinley
jmeador

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rP7729c51cc4f2: Fix an issue where scrolling down, then up, then down fails to show changeset…

Summary

Ref T13151. See PHI616. There's a bug where the current banner changeset isn't cleared correctly when we hide the banner.

Test Plan

View revision with several changesets.
Scroll down slowly through first changeset until banner appears.
Scroll up until banner disappears.
Scroll back down.
Before: banner fails to reappear (code still thinks it's visible and we don't want to update it).
After: banner reappears correctly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 7 2018, 4:45 PM

Harbormaster completed remote builds in B20381: Diff 46577.Jun 7 2018, 4:46 PM

epriestley requested review of this revision.Jun 7 2018, 4:46 PM

jmeador accepted this revision.Jun 7 2018, 5:30 PM

This revision is now accepted and ready to land.Jun 7 2018, 5:30 PM

Closed by commit rP7729c51cc4f2: Fix an issue where scrolling down, then up, then down fails to show changeset… (authored by epriestley). · Explain WhyJun 7 2018, 7:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

1 line

Diff 46583

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...