Paths

Table of Contentst

Differential D19476

Include owners packages in the MailableFunction datasource
ClosedPublic
Actions

Authored by epriestley on Jun 7 2018, 5:01 PM.

Details

Reviewers

amckinley
jmeador

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rP2951e0c86bfa: Include owners packages in the MailableFunction datasource

Summary

Ref T13151. See PHI684. Currently, the MailableFunction datasource does not include Owners packages, but they are valid subscribers and the Mailable datasource includes them.

Include them in the MailableFunction datasource, too.

Test Plan

Searched for revisions with particular package subscribers, got expected results in the UI (tokenizer knew about packages) and response.

Diff Detail

Repository

rP Phabricator

Branch

mailable1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20383
Build 27680: Run Core Tests
Build 27679: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 7 2018, 5:01 PM

Harbormaster completed remote builds in B20383: Diff 46579.Jun 7 2018, 5:02 PM

epriestley requested review of this revision.Jun 7 2018, 5:02 PM

jmeador accepted this revision.Jun 7 2018, 5:28 PM

jmeador awarded a token.

This revision is now accepted and ready to land.Jun 7 2018, 5:28 PM

Closed by commit rP2951e0c86bfa: Include owners packages in the MailableFunction datasource (authored by epriestley). · Explain WhyJun 7 2018, 7:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

typeahead/

PhabricatorMetaMTAMailableFunctionDatasource.php

4 lines

search/

field/

PhabricatorSearchSubscribersField.php

1 line

Diff 46579

View Options

src/applications/metamta/typeahead/PhabricatorMetaMTAMailableFunctionDatasource.php