Differential D19474

Fix an issue where scrolling down, then up, then down fails to show changeset header in Differential
ClosedPublic
Actions

Authored by epriestley on Jun 7 2018, 4:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 4, 12:40 AM

	Unknown Object (File)
	Dec 20 2024, 8:56 PM

	Unknown Object (File)
	Dec 12 2024, 6:11 PM

	Unknown Object (File)
	Dec 10 2024, 2:57 PM

	Unknown Object (File)
	Nov 29 2024, 4:20 PM

	Unknown Object (File)
	Nov 28 2024, 8:22 AM

	Unknown Object (File)
	Nov 27 2024, 4:21 PM

	Unknown Object (File)
	Nov 27 2024, 4:05 AM

Subscribers

None

Details

Reviewers

amckinley
jmeador

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rP7729c51cc4f2: Fix an issue where scrolling down, then up, then down fails to show changeset…

Summary

Ref T13151. See PHI616. There's a bug where the current banner changeset isn't cleared correctly when we hide the banner.

Test Plan

View revision with several changesets.
Scroll down slowly through first changeset until banner appears.
Scroll up until banner disappears.
Scroll back down.
Before: banner fails to reappear (code still thinks it's visible and we don't want to update it).
After: banner reappears correctly.

Diff Detail

Repository

Branch

header1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20381
Build 27676: Run Core Tests
Build 27675: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 7 2018, 4:45 PM

Harbormaster completed remote builds in B20381: Diff 46577.Jun 7 2018, 4:46 PM

epriestley requested review of this revision.Jun 7 2018, 4:46 PM

jmeador accepted this revision.Jun 7 2018, 5:30 PM

This revision is now accepted and ready to land.Jun 7 2018, 5:30 PM

Closed by commit rP7729c51cc4f2: Fix an issue where scrolling down, then up, then down fails to show changeset… (authored by epriestley). · Explain WhyJun 7 2018, 7:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

1 line

Diff 46577

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...