Paths

Table of Contentst

Differential D19457

Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI
ClosedPublic
Actions

Authored by epriestley on Jun 1 2018, 8:14 PM.

Details

Reviewers

amckinley
avivey

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types
T13148: css: ginormous images go over preview panel in Files

Commits

rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering…

Summary

Fixes T13148. Ref T13105. The new document rendering engine for images let them overflow the UI bounds.

Add max-width: 100%; to keep them contained.

Test Plan

Viewed a very wide image in Safari, Firefox and Chrome. Saw sensible rendering.
Also viewed a normal image, saw normal behavior.

Diff Detail

Repository

rP Phabricator

Branch

width1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20353
Build 27641: Run Core Tests
Build 27640: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 1 2018, 8:14 PM

Harbormaster completed remote builds in B20353: Diff 46544.Jun 1 2018, 8:15 PM

epriestley requested review of this revision.Jun 1 2018, 8:15 PM

lgtm

This revision is now accepted and ready to land.Jun 1 2018, 8:24 PM

Closed by commit rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering… (authored by epriestley). · Explain WhyJun 1 2018, 9:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

phui/

phui-property-list-view.css

1 line

Diff 46544

View Options

resources/celerity/map.php