Page MenuHomePhabricator

Raise the intraline diff hard limit from 80 to 100 characters
ClosedPublic

Authored by epriestley on May 9 2018, 8:33 PM.
Tags
None
Referenced Files
F15407113: D19442.diff
Tue, Mar 18, 3:49 PM
F15379741: D19442.id46503.diff
Thu, Mar 13, 11:09 PM
Unknown Object (File)
Sun, Mar 2, 6:35 PM
Unknown Object (File)
Thu, Feb 27, 2:26 AM
Unknown Object (File)
Wed, Feb 26, 10:57 PM
Unknown Object (File)
Wed, Feb 26, 9:58 AM
Unknown Object (File)
Wed, Feb 26, 2:55 AM
Unknown Object (File)
Tue, Feb 25, 6:13 PM
Subscribers
None

Details

Summary

Fixes T1246. See PHI637. See T13137. Computers have gotten a bit faster so we can probably bump this up a little and see if it causes problems. This is O(N^2) so the this should be less than twice as expensive in the worst case.

Test Plan

Created a diff affecting characters on a very long line separated by more than 80 but fewer than 100 characters, got a good intraline diff out of it:

Screen Shot 2018-05-09 at 1.30.52 PM.png (1×2 px, 243 KB)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable