Page MenuHomePhabricator

Raise the intraline diff hard limit from 80 to 100 characters
ClosedPublic

Authored by epriestley on May 9 2018, 8:33 PM.
Tags
None
Referenced Files
F13326658: D19442.diff
Sat, Jun 15, 8:12 AM
F13310886: D19442.id46503.diff
Mon, Jun 10, 9:33 PM
F13287319: D19442.diff
Tue, Jun 4, 8:36 AM
F13274596: D19442.diff
Fri, May 31, 3:53 AM
F13240144: D19442.diff
Wed, May 22, 10:55 AM
F13234755: D19442.diff
Tue, May 21, 3:43 AM
F13216015: D19442.id46503.diff
Fri, May 17, 9:51 PM
F13215621: D19442.id46504.diff
Fri, May 17, 6:41 PM
Subscribers
None

Details

Summary

Fixes T1246. See PHI637. See T13137. Computers have gotten a bit faster so we can probably bump this up a little and see if it causes problems. This is O(N^2) so the this should be less than twice as expensive in the worst case.

Test Plan

Created a diff affecting characters on a very long line separated by more than 80 but fewer than 100 characters, got a good intraline diff out of it:

Screen Shot 2018-05-09 at 1.30.52 PM.png (1×2 px, 243 KB)

Diff Detail

Repository
rARC Arcanist
Branch
intra1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20309
Build 27573: Run Core Tests
Build 27572: arc lint + arc unit