Raise the intraline diff hard limit from 80 to 100 characters
ClosedPublic
Actions

Authored by epriestley on May 9 2018, 8:33 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T1246: Intraline diff bailout at 80 characters is inflexible and undesirable

Commits

rARCa1aec701e3ea: Raise the intraline diff hard limit from 80 to 100 characters

Summary

Fixes T1246. See PHI637. See T13137. Computers have gotten a bit faster so we can probably bump this up a little and see if it causes problems. This is O(N^2) so the this should be less than twice as expensive in the worst case.

Test Plan

Created a diff affecting characters on a very long line separated by more than 80 but fewer than 100 characters, got a good intraline diff out of it:

Screen Shot 2018-05-09 at 1.30.52 PM.png (1×2 px, 243 KB)

Diff Detail

Repository

rARC Arcanist

Branch

intra1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20309
Build 27573: Run Core Tests
Build 27572: arc lint + arc unit

Event Timeline

epriestley created this revision.May 9 2018, 8:33 PM

Harbormaster completed remote builds in B20309: Diff 46503.May 9 2018, 8:34 PM

epriestley requested review of this revision.May 9 2018, 8:34 PM

amckinley accepted this revision.May 9 2018, 8:37 PM

amckinley added inline comments.

src/difference/ArcanistDiffUtils.php
66	Why not go all the way to 120?

This revision is now accepted and ready to land.May 9 2018, 8:37 PM

epriestley mentioned this in T1246: Intraline diff bailout at 80 characters is inflexible and undesirable.May 9 2018, 8:37 PM

Closed by commit rARCa1aec701e3ea: Raise the intraline diff hard limit from 80 to 100 characters (authored by epriestley). · Explain WhyMay 9 2018, 8:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

difference/

ArcanistDiffUtils.php

2 lines

Diff 46503

View Options

src/difference/ArcanistDiffUtils.php

Raise the intraline diff hard limit from 80 to 100 charactersClosedPublicActions