Page MenuHomePhabricator
Differential D19433

Improve UI and documentation for "Ignore Attributes" in Owners slightly
ClosedPublic
Actions

Authored by epriestley on May 7 2018, 9:20 PM.
Tags
None
Referenced Files
F15478301: D19433.id46484.diff
Mon, Apr 7, 9:51 PM
F15451861: D19433.id46484.diff
Sat, Mar 29, 12:11 AM
F15439241: D19433.id.diff
Wed, Mar 26, 6:31 AM
F15438539: D19433.id46484.diff
Wed, Mar 26, 1:20 AM
F15436232: D19433.diff
Tue, Mar 25, 12:46 PM
F15341310: D19433.diff
Mar 9 2025, 7:39 PM
F15337150: D19433.id46480.diff
Mar 9 2025, 4:26 AM
Unknown Object (File)
Feb 28 2025, 3:09 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13137: Plans: 2018 Week 19 - Week 22 Bonus Content
Commits
rP304c6a45976d: Improve UI and documentation for "Ignore Attributes" in Owners slightly
Summary

See PHI251. Ref T13137.

  • Replace the perplexing text box with a checkbox that explains what it does.
  • Mention this feature in the documentation.
Test Plan
  • Clicked/unclicked checkbox.
  • Read documentation.
  • Used an existing checkbox control in Slowvote to make sure I didn't break it.

Diff Detail

Repository
rP Phabricator
Branch
odoc1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20291
Build 27547: Run Core Tests
Build 27546: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
editor/
8 lines
transactions/
editfield/
36 lines
docs/
user/
userguide/
15 lines
view/
form/
control/
32 lines

Diff 46480

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorCheckboxesEditField.php

Loading...
View Options

src/docs/user/userguide/owners.diviner

Loading...
View Options

src/view/form/control/AphrontFormCheckboxControl.php

Loading...
Phabricator · Built by Phacility