Differential D19433

Improve UI and documentation for "Ignore Attributes" in Owners slightly
ClosedPublic
Actions

Authored by epriestley on May 7 2018, 9:20 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13137: Plans: 2018 Week 19 - Week 22 Bonus Content

Commits

rP304c6a45976d: Improve UI and documentation for "Ignore Attributes" in Owners slightly

Summary

See PHI251. Ref T13137.

Replace the perplexing text box with a checkbox that explains what it does.
Mention this feature in the documentation.

Test Plan

Clicked/unclicked checkbox.
Read documentation.
Used an existing checkbox control in Slowvote to make sure I didn't break it.

Diff Detail

Repository

rP Phabricator

Branch

odoc1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20291
Build 27547: Run Core Tests
Build 27546: arc lint + arc unit

Event Timeline

epriestley created this revision.May 7 2018, 9:20 PM

Harbormaster completed remote builds in B20291: Diff 46480.May 7 2018, 9:21 PM

epriestley requested review of this revision.May 7 2018, 9:21 PM

amckinley accepted this revision.May 7 2018, 11:25 PM

This revision is now accepted and ready to land.May 7 2018, 11:25 PM

Closed by commit rP304c6a45976d: Improve UI and documentation for "Ignore Attributes" in Owners slightly (authored by epriestley). · Explain WhyMay 8 2018, 9:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

owners/

editor/

PhabricatorOwnersPackageEditEngine.php

8 lines

transactions/

editfield/

PhabricatorCheckboxesEditField.php

36 lines

docs/

user/

userguide/

owners.diviner

15 lines

view/

form/

control/

AphrontFormCheckboxControl.php

32 lines

Diff 46480

View Options

src/__phutil_library_map__.php

View Options

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

View Options

src/applications/transactions/editfield/PhabricatorCheckboxesEditField.php

View Options

src/docs/user/userguide/owners.diviner

View Options

src/view/form/control/AphrontFormCheckboxControl.php

Improve UI and documentation for "Ignore Attributes" in Owners slightlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46480

src/__phutil_library_map__.php

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

src/applications/transactions/editfield/PhabricatorCheckboxesEditField.php

src/docs/user/userguide/owners.diviner

src/view/form/control/AphrontFormCheckboxControl.php

Improve UI and documentation for "Ignore Attributes" in Owners slightly
ClosedPublic
Actions

Revision Contents
Changeset List