Page MenuHomePhabricator

Mention the "inline comments" rule in the callout for "Large" diffs
ClosedPublic

Authored by epriestley on May 6 2018, 1:32 PM.
Tags
None
Referenced Files
F15285559: D19430.id46476.diff
Tue, Mar 4, 2:29 PM
Unknown Object (File)
Sat, Feb 22, 7:32 PM
Unknown Object (File)
Sat, Feb 22, 7:27 PM
Unknown Object (File)
Sat, Feb 22, 7:20 PM
Unknown Object (File)
Thu, Feb 20, 9:57 PM
Unknown Object (File)
Thu, Feb 20, 9:57 PM
Unknown Object (File)
Thu, Feb 20, 9:57 PM
Unknown Object (File)
Thu, Feb 20, 9:57 PM
Subscribers
None

Details

Summary

See PHI638. When a diff is large (between 100 and 1000 files), we collapse content by default unless a change also has inline comments.

This rule isn't explicitly explained anywhere. Although it's not really a critical rule, it fits easily enough into the UI callout.

Also render the UI callout in a slightly more modern way and avoid hsprintf().

Test Plan

Screen Shot 2018-05-06 at 6.30.16 AM.png (1×1 px, 216 KB)

  • Also, clicked the "Expand" link and saw everything expand properly.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20287
Build 27540: Run Core Tests
Build 27539: arc lint + arc unit