Page MenuHomePhabricator

Mention the "inline comments" rule in the callout for "Large" diffs
ClosedPublic

Authored by epriestley on May 6 2018, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 1, 8:15 AM
Unknown Object (File)
Sun, Jun 1, 5:09 AM
Unknown Object (File)
Sat, May 31, 10:16 AM
Unknown Object (File)
Fri, May 30, 8:16 PM
Unknown Object (File)
May 5 2025, 11:31 PM
Unknown Object (File)
May 3 2025, 9:02 AM
Unknown Object (File)
Apr 21 2025, 8:15 AM
Unknown Object (File)
Apr 19 2025, 10:55 AM
Subscribers
None

Details

Summary

See PHI638. When a diff is large (between 100 and 1000 files), we collapse content by default unless a change also has inline comments.

This rule isn't explicitly explained anywhere. Although it's not really a critical rule, it fits easily enough into the UI callout.

Also render the UI callout in a slightly more modern way and avoid hsprintf().

Test Plan

Screen Shot 2018-05-06 at 6.30.16 AM.png (1×1 px, 216 KB)

  • Also, clicked the "Expand" link and saw everything expand properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable