Page MenuHomePhabricator

Fix an issue where the Herald test console doesn't work with "Content source" rules
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:16 PM.
Tags
None
Referenced Files
F15440829: D19411.id46425.diff
Wed, Mar 26, 2:51 PM
F15439800: D19411.id46432.diff
Wed, Mar 26, 9:32 AM
F15436412: D19411.id.diff
Tue, Mar 25, 1:59 PM
F15430421: D19411.diff
Mon, Mar 24, 7:36 AM
F15424208: D19411.id46425.diff
Sat, Mar 22, 8:53 PM
Unknown Object (File)
Mar 3 2025, 9:13 PM
Unknown Object (File)
Feb 20 2025, 9:51 PM
Unknown Object (File)
Feb 20 2025, 9:51 PM
Subscribers
None

Details

Summary

Ref T13130. See PHI619. Currently, the Herald "Test Console" doesn't pass a "Content Source" to the adapter, so if any rules of the given type execute a "Content source" field rule, they'll fatal.

Provide a content source:

  • If possible, use the content source from the most recent transaction.
  • Otherwise, build a default "web" content source from the current request.
Test Plan
  • Wrote a "When [content source][is][whatever]" rule for tasks.
  • Ran test console against a task.
  • Before: got a fatal trying to interact with the content source.
  • After: transcript reports sensible content source.
    • Also commented out the "xaction" logic to test the fallback behavior.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20234
Build 27463: Run Core Tests
Build 27462: arc lint + arc unit