Page MenuHomePhabricator

Fix an issue where the Herald test console doesn't work with "Content source" rules
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:16 PM.
Tags
None
Referenced Files
F17320291: D19411.diff
Thu, Jun 26, 8:16 PM
Unknown Object (File)
Thu, Jun 5, 7:13 AM
Unknown Object (File)
Fri, May 30, 1:07 PM
Unknown Object (File)
Fri, May 30, 7:53 AM
Unknown Object (File)
Wed, May 28, 1:28 PM
Unknown Object (File)
May 27 2025, 8:04 AM
Unknown Object (File)
Apr 28 2025, 12:28 PM
Unknown Object (File)
Apr 26 2025, 10:37 PM
Subscribers
None

Details

Summary

Ref T13130. See PHI619. Currently, the Herald "Test Console" doesn't pass a "Content Source" to the adapter, so if any rules of the given type execute a "Content source" field rule, they'll fatal.

Provide a content source:

  • If possible, use the content source from the most recent transaction.
  • Otherwise, build a default "web" content source from the current request.
Test Plan
  • Wrote a "When [content source][is][whatever]" rule for tasks.
  • Ran test console against a task.
  • Before: got a fatal trying to interact with the content source.
  • After: transcript reports sensible content source.
    • Also commented out the "xaction" logic to test the fallback behavior.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20234
Build 27463: Run Core Tests
Build 27462: arc lint + arc unit