Page MenuHomePhabricator

Fix an issue where the Herald test console doesn't work with "Content source" rules
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 14 2024, 10:07 AM
Unknown Object (File)
Oct 9 2024, 9:30 AM
Unknown Object (File)
Oct 7 2024, 1:57 AM
Unknown Object (File)
Oct 1 2024, 2:18 PM
Unknown Object (File)
Sep 23 2024, 11:57 PM
Unknown Object (File)
Sep 15 2024, 4:25 AM
Unknown Object (File)
Sep 13 2024, 2:09 PM
Unknown Object (File)
Sep 6 2024, 3:17 AM
Subscribers
None

Details

Summary

Ref T13130. See PHI619. Currently, the Herald "Test Console" doesn't pass a "Content Source" to the adapter, so if any rules of the given type execute a "Content source" field rule, they'll fatal.

Provide a content source:

  • If possible, use the content source from the most recent transaction.
  • Otherwise, build a default "web" content source from the current request.
Test Plan
  • Wrote a "When [content source][is][whatever]" rule for tasks.
  • Ran test console against a task.
  • Before: got a fatal trying to interact with the content source.
  • After: transcript reports sensible content source.
    • Also commented out the "xaction" logic to test the fallback behavior.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20234
Build 27463: Run Core Tests
Build 27462: arc lint + arc unit