Page MenuHomePhabricator

Fix an issue where the Herald test console doesn't work with "Content source" rules
ClosedPublic

Authored by epriestley on Apr 27 2018, 6:16 PM.
Tags
None
Referenced Files
F22188260: D19411.diff
Tue, Aug 25, 10:40 AM
Unknown Object (File)
Wed, Aug 19, 4:01 PM
Unknown Object (File)
Sat, Aug 8, 6:56 PM
Unknown Object (File)
Jun 5 2026, 12:42 AM
Unknown Object (File)
Dec 21 2025, 9:12 PM
Unknown Object (File)
Nov 3 2025, 12:39 PM
Unknown Object (File)
Oct 30 2025, 2:53 PM
Unknown Object (File)
Oct 29 2025, 9:16 AM
Subscribers
None

Details

Summary

Ref T13130. See PHI619. Currently, the Herald "Test Console" doesn't pass a "Content Source" to the adapter, so if any rules of the given type execute a "Content source" field rule, they'll fatal.

Provide a content source:

  • If possible, use the content source from the most recent transaction.
  • Otherwise, build a default "web" content source from the current request.
Test Plan
  • Wrote a "When [content source][is][whatever]" rule for tasks.
  • Ran test console against a task.
  • Before: got a fatal trying to interact with the content source.
  • After: transcript reports sensible content source.
    • Also commented out the "xaction" logic to test the fallback behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable