Page MenuHomePhabricator

Remove unusual unicode marks in Differential action dropdown
ClosedPublic

Authored by epriestley on Apr 25 2018, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 9:49 PM
Unknown Object (File)
Thu, Feb 20, 9:49 PM
Unknown Object (File)
Thu, Feb 20, 9:49 PM
Unknown Object (File)
Thu, Feb 20, 9:49 PM
Unknown Object (File)
Feb 9 2025, 5:58 AM
Unknown Object (File)
Feb 9 2025, 5:58 AM
Unknown Object (File)
Feb 9 2025, 5:58 AM
Unknown Object (File)
Feb 9 2025, 5:58 AM
Subscribers
None

Details

Summary

See https://twitter.com/HayleyCAnderson/status/988873585363009536.

Currently, the action dropdown in Differential shows a heavy "X" after "Request Changes" and a heavy checkmark after "Accept Revision".

Although I'm not convinced that the messaging around "Request Changes" is too strong, I do think these marks are out of place in modern Differential. They came from a simpler time when this dropdown had fewer actions, but feel a little weird and inconsistent to me in the modern UI.

Let's try getting rid of them and see how it goes?

Test Plan
  • Viewed these actions in the dropdown, no longer saw the mark icons.
  • Grepped for these unicode sequences without getting any other hits.

Diff Detail

Repository
rP Phabricator
Branch
removex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20223
Build 27446: Run Core Tests
Build 27445: arc lint + arc unit