Page MenuHomePhabricator

Remove unusual unicode marks in Differential action dropdown
ClosedPublic

Authored by epriestley on Apr 25 2018, 1:24 PM.
Tags
None
Referenced Files
F17325053: D19405.diff
Fri, Jun 27, 12:44 AM
F17321556: D19405.id46424.diff
Thu, Jun 26, 9:40 PM
Unknown Object (File)
Fri, May 30, 4:16 AM
Unknown Object (File)
Thu, May 29, 7:35 PM
Unknown Object (File)
Wed, May 28, 11:46 AM
Unknown Object (File)
May 25 2025, 11:07 AM
Unknown Object (File)
May 9 2025, 12:43 PM
Unknown Object (File)
May 8 2025, 3:20 AM
Subscribers
None

Details

Summary

See https://twitter.com/HayleyCAnderson/status/988873585363009536.

Currently, the action dropdown in Differential shows a heavy "X" after "Request Changes" and a heavy checkmark after "Accept Revision".

Although I'm not convinced that the messaging around "Request Changes" is too strong, I do think these marks are out of place in modern Differential. They came from a simpler time when this dropdown had fewer actions, but feel a little weird and inconsistent to me in the modern UI.

Let's try getting rid of them and see how it goes?

Test Plan
  • Viewed these actions in the dropdown, no longer saw the mark icons.
  • Grepped for these unicode sequences without getting any other hits.

Diff Detail

Repository
rP Phabricator
Branch
removex1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20223
Build 27446: Run Core Tests
Build 27445: arc lint + arc unit