Details
Details
Submitted some metrics, saw them show up.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 20143 Build 27328: Run Core Tests Build 27327: arc lint + arc unit
Event Timeline
src/future/aws/PhutilCloudWatchMetric.php | ||
---|---|---|
47 | I think this construction means that adding the same dimension with different values will silently do nothing the second time, which is maybe a little weird: $metric->addDimension('a', 1); $metric->addDimension('a', 2); // Does nothing. Consider: $this->dimensions[$name] = $value; ...to make a second call override, or an array_key_exists() test plus throw ... to make a second call an error. |