Page MenuHomePhabricator

Initial CloudWatch metric reporting support
ClosedPublic

Authored by amckinley on Apr 12 2018, 11:25 PM.
Tags
None
Referenced Files
F17332231: D19363.diff
Fri, Jun 27, 8:30 AM
Unknown Object (File)
Fri, Jun 6, 2:55 AM
Unknown Object (File)
Mon, Jun 2, 1:38 PM
Unknown Object (File)
May 7 2025, 6:31 PM
Unknown Object (File)
Apr 26 2025, 1:34 AM
Unknown Object (File)
Apr 16 2025, 1:09 PM
Unknown Object (File)
Apr 12 2025, 9:44 AM
Unknown Object (File)
Apr 5 2025, 1:36 PM
Subscribers

Details

Summary

Ref T12857. Ref T13076. Initial infrastrucutre for creating and submitting CloudWatch metrics to AWS.

Test Plan

Submitted some metrics, saw them show up.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20137
Build 27319: Run Core Tests
Build 27318: arc lint + arc unit

Event Timeline

wrong concatenation operator

epriestley added inline comments.
src/future/aws/PhutilCloudWatchMetric.php
46

I think this construction means that adding the same dimension with different values will silently do nothing the second time, which is maybe a little weird:

$metric->addDimension('a', 1);
$metric->addDimension('a', 2); // Does nothing.

Consider:

$this->dimensions[$name] = $value;

...to make a second call override, or an array_key_exists() test plus throw ... to make a second call an error.

This revision is now accepted and ready to land.Apr 13 2018, 11:53 AM
This revision was automatically updated to reflect the committed changes.