Page MenuHomePhabricator

Initial CloudWatch metric reporting support
ClosedPublic

Authored by amckinley on Apr 12 2018, 11:25 PM.
Tags
None
Referenced Files
F13204885: D19363.diff
Wed, May 15, 1:12 AM
F13191971: D19363.id46328.diff
Sun, May 12, 3:32 AM
F13189361: D19363.diff
Sat, May 11, 5:53 AM
Unknown Object (File)
Tue, Apr 30, 11:30 PM
Unknown Object (File)
Sat, Apr 27, 11:21 AM
Unknown Object (File)
Mon, Apr 22, 10:49 PM
Unknown Object (File)
Fri, Apr 19, 9:56 PM
Unknown Object (File)
Fri, Apr 19, 7:40 PM
Subscribers

Details

Summary

Ref T12857. Ref T13076. Initial infrastrucutre for creating and submitting CloudWatch metrics to AWS.

Test Plan

Submitted some metrics, saw them show up.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20143
Build 27328: Run Core Tests
Build 27327: arc lint + arc unit

Event Timeline

wrong concatenation operator

epriestley added inline comments.
src/future/aws/PhutilCloudWatchMetric.php
47

I think this construction means that adding the same dimension with different values will silently do nothing the second time, which is maybe a little weird:

$metric->addDimension('a', 1);
$metric->addDimension('a', 2); // Does nothing.

Consider:

$this->dimensions[$name] = $value;

...to make a second call override, or an array_key_exists() test plus throw ... to make a second call an error.

This revision is now accepted and ready to land.Apr 13 2018, 11:53 AM
This revision was automatically updated to reflect the committed changes.