Differential D19298

Remove "Large Changes" documentation and make some minor behavioral improvements
ClosedPublic
Actions

Authored by epriestley on Apr 5 2018, 1:29 PM.

Tags

None

Referenced Files

	F13168822: D19298.diff
	Tue, May 7, 7:58 AM

	Unknown Object (File)
	Fri, May 3, 7:42 AM

	Unknown Object (File)
	Thu, Apr 25, 1:41 AM

	Unknown Object (File)
	Fri, Apr 19, 7:38 PM

	Unknown Object (File)
	Thu, Apr 18, 3:54 PM

	Unknown Object (File)
	Wed, Apr 17, 2:32 PM

	Unknown Object (File)
	Wed, Apr 17, 1:33 PM

	Unknown Object (File)
	Thu, Apr 11, 5:29 PM

View All 82 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rPf01c2e36948b: Remove "Large Changes" documentation and make some minor behavioral improvements

Summary

Depends on D19296. Ref T13110.

Remove the "Large Changesets" documentation since we now degrade very large changesets and I don't have any evidence that anyone has ever tried to follow any of the recommendations in this document.
Remove references to it.
When an older revision doesn't have denormalized size information on the Revision object itself, don't render a scale element (instead of rendering a bogus one).
Try to improve terminology consistency around "Large Change" (100-1000 files) vs "Very Large Change" (1000+ files) vs "Enormous Change" (too large to hold in memory).

Test Plan

Viewed revisions; grepped for documentation.

Diff Detail

Repository

Branch

hefty3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20004
Build 27124: Run Core Tests
Build 27123: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 5 2018, 1:29 PM

Harbormaster completed remote builds in B20004: Diff 46182.Apr 5 2018, 1:30 PM

epriestley requested review of this revision.Apr 5 2018, 1:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:40 PM

Closed by commit rPf01c2e36948b: Remove "Large Changes" documentation and make some minor behavioral improvements (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialCreateRawDiffConduitAPIMethod.php

5 lines

controller/

DifferentialRevisionViewController.php

2 lines

storage/

DifferentialRevision.php

6 lines

view/

DifferentialRevisionListView.php

9 lines

docs/

flavor/

writing_reviewable_code.diviner

3 lines

user/

userguide/

differential.diviner

2 lines

differential_large_changes.diviner

Diff 46182

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

Loading...

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/differential/view/DifferentialRevisionListView.php

Loading...

src/docs/flavor/writing_reviewable_code.diviner

Loading...

src/docs/user/userguide/differential.diviner

Loading...

src/docs/user/userguide/differential_large_changes.diviner

Loading...