Page MenuHomePhabricator

Remove "Large Changes" documentation and make some minor behavioral improvements
ClosedPublic

Authored by epriestley on Apr 5 2018, 1:29 PM.
Tags
None
Referenced Files
F18812472: D19298.diff
Mon, Oct 20, 9:37 AM
F18789045: D19298.id.diff
Wed, Oct 15, 7:41 AM
F18745722: D19298.id46186.diff
Fri, Oct 3, 8:58 AM
F18509511: D19298.id.diff
Sep 5 2025, 3:26 AM
F18502573: D19298.diff
Sep 4 2025, 10:31 PM
F18221785: D19298.id.diff
Aug 19 2025, 7:12 PM
F18207319: D19298.diff
Aug 18 2025, 5:25 PM
F17689934: D19298.id46186.diff
Jul 14 2025, 2:38 PM
Subscribers
None

Details

Summary

Depends on D19296. Ref T13110.

  • Remove the "Large Changesets" documentation since we now degrade very large changesets and I don't have any evidence that anyone has ever tried to follow any of the recommendations in this document.
  • Remove references to it.
  • When an older revision doesn't have denormalized size information on the Revision object itself, don't render a scale element (instead of rendering a bogus one).
  • Try to improve terminology consistency around "Large Change" (100-1000 files) vs "Very Large Change" (1000+ files) vs "Enormous Change" (too large to hold in memory).
Test Plan

Viewed revisions; grepped for documentation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:40 PM
This revision was automatically updated to reflect the committed changes.