Differential D19296

When a revision changes more than 1,000 files, don't show the changes on the main page
ClosedPublic
Actions

Authored by epriestley on Apr 4 2018, 1:51 PM.

Tags

None

Referenced Files

	F18963669: D19296.id.diff
	Nov 14 2025, 1:19 AM

	F18873093: D19296.id.diff
	Nov 5 2025, 7:54 AM

	F18770908: D19296.id46179.diff
	Oct 8 2025, 4:06 PM

	F18657016: D19296.diff
	Sep 23 2025, 12:12 AM

	F18509509: D19296.id.diff
	Sep 5 2025, 3:26 AM

	F18502568: D19296.diff
	Sep 4 2025, 10:31 PM

	F18101366: D19296.id46179.diff
	Aug 9 2025, 12:32 PM

	F18095031: D19296.id.diff
	Aug 7 2025, 10:30 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rP1b363a831e7c: When a revision changes more than 1,000 files, don't show the changes on the…

Summary

Depends on D19295. Ref T13110. Degrade the review UX when users try to interact with changes which are too large to receive human review.

Test Plan

Reduced the "very large" limit, browsed some changes, saw various elements degrade.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 4 2018, 1:51 PM

Harbormaster completed remote builds in B20000: Diff 46179.Apr 4 2018, 1:52 PM

epriestley requested review of this revision.Apr 4 2018, 1:52 PM

epriestley added a child revision: D19298: Remove "Large Changes" documentation and make some minor behavioral improvements.Apr 5 2018, 1:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:40 PM

Closed by commit rP1b363a831e7c: When a revision changes more than 1,000 files, don't show the changes on the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

110 lines

Diff 46185

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

When a revision changes more than 1,000 files, don't show the changes on the main pageClosedPublicActions