Differential D19295

Add a standalone view for browsing changesets of very large revisions
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 11:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 8:05 PM

	Unknown Object (File)
	Thu, Apr 11, 10:36 AM

	Unknown Object (File)
	Sun, Mar 31, 2:16 PM

	Unknown Object (File)
	Sat, Mar 30, 4:32 PM

	Unknown Object (File)
	Sat, Mar 30, 4:32 PM

	Unknown Object (File)
	Sat, Mar 30, 4:32 PM

	Unknown Object (File)
	Feb 18 2024, 2:17 AM

	Unknown Object (File)
	Feb 9 2024, 9:14 AM

View All 80 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rP8c8e7f07b575: Add a standalone view for browsing changesets of very large revisions

Summary

Ref T13110. Installs have various reasons for sending unreviewable changes (changes where the text of the change will never be reviewed by a human) through Differential anyway. Prepare for accommodating this more gracefully by building a standalone changeset list page which paginates the changesets.

Test Plan

Clicked the new "Changeset List" button on a revision, was taken to a separate page.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 3 2018, 11:36 PM

Harbormaster completed remote builds in B19999: Diff 46178.Apr 3 2018, 11:38 PM

epriestley requested review of this revision.Apr 3 2018, 11:38 PM

epriestley added a child revision: D19296: When a revision changes more than 1,000 files, don't show the changes on the main page.Apr 4 2018, 1:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:35 PM

Closed by commit rP8c8e7f07b575: Add a standalone view for browsing changesets of very large revisions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

differential/

application/

PhabricatorDifferentialApplication.php

8 lines

controller/

DifferentialChangesetListController.php

51 lines

DifferentialRevisionViewController.php

12 lines

query/

DifferentialChangesetQuery.php

29 lines

DifferentialChangesetSearchEngine.php

133 lines

Diff 46184

src/__phutil_library_map__.php

Loading...

src/applications/differential/application/PhabricatorDifferentialApplication.php

Loading...

src/applications/differential/controller/DifferentialChangesetListController.php

Loading...

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/differential/query/DifferentialChangesetQuery.php

Loading...

src/applications/differential/query/DifferentialChangesetSearchEngine.php

Loading...