Page MenuHomePhabricator

Make Harbormaster objects destructible
ClosedPublic

Authored by epriestley on Mar 29 2018, 7:58 PM.
Tags
None
Referenced Files
F17522626: D19269.id46126.diff
Thu, Jul 3, 6:16 AM
Unknown Object (File)
Sun, Jun 29, 3:05 PM
Unknown Object (File)
May 30 2025, 4:49 PM
Unknown Object (File)
May 28 2025, 3:33 PM
Unknown Object (File)
May 27 2025, 6:13 AM
Unknown Object (File)
Apr 28 2025, 5:35 PM
Unknown Object (File)
Apr 26 2025, 2:53 PM
Unknown Object (File)
Apr 25 2025, 7:00 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13114. See PHI511. Ref T13072. This makes Buildables, Builds, Targets and Artifacts destructible with bin/remove destroy.

This might not be totally exhaustive. In particular:

  • File artifacts won't destroy the file. This is sort of okay because file artifacts are currently just a file reference, but probably shouldn't be how things work in the long term.
  • BuildCommand doesn't get cleaned up, but BuildMessage does on Build. See T13072 for more.
Test Plan

Used bin/remove destroy to nuke a bunch of builds, buildables, etc. Loaded stuff in the web UI and it all looked like it got nuked properly.

Diff Detail

Repository
rP Phabricator
Branch
destroy1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19947
Build 27040: Run Core Tests
Build 27039: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 29 2018, 7:58 PM
epriestley retitled this revision from Make Harbormaster object destructible to Make Harbormaster objects destructible.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 8:01 PM
This revision was automatically updated to reflect the committed changes.