Paths

Table of Contentst

Differential D19269

Make Harbormaster objects destructible
ClosedPublic
Actions

Authored by epriestley on Mar 29 2018, 7:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 28, 2:30 AM

	Unknown Object (File)
	Thu, Nov 28, 2:30 AM

	Unknown Object (File)
	Thu, Nov 28, 2:30 AM

	Unknown Object (File)
	Thu, Nov 28, 2:06 AM

	Unknown Object (File)
	Tue, Nov 19, 2:39 PM

	Unknown Object (File)
	Thu, Nov 14, 9:40 PM

	Unknown Object (File)
	Mon, Nov 11, 5:09 AM

	Unknown Object (File)
	Thu, Nov 7, 2:31 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13072: Merge Harbormaster BuildCommand into BuildMessage
T13114: Plans: 2018 Week 13 Bonus Content
Commits: rP7f9a9bc800f7: Make Harbormaster objects destructible

Summary

Ref T13114. See PHI511. Ref T13072. This makes Buildables, Builds, Targets and Artifacts destructible with bin/remove destroy.

This might not be totally exhaustive. In particular:

File artifacts won't destroy the file. This is sort of okay because file artifacts are currently just a file reference, but probably shouldn't be how things work in the long term.
BuildCommand doesn't get cleaned up, but BuildMessage does on Build. See T13072 for more.

Test Plan

Used bin/remove destroy to nuke a bunch of builds, buildables, etc. Loaded stuff in the web UI and it all looked like it got nuked properly.

Diff Detail

Repository

Branch

destroy1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19947
Build 27040: Run Core Tests
Build 27039: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 29 2018, 7:58 PM

Owners added a subscriber: Restricted Owners Package.Mar 29 2018, 7:58 PM

Harbormaster completed remote builds in B19947: Diff 46126.Mar 29 2018, 7:59 PM

epriestley requested review of this revision.Mar 29 2018, 7:59 PM

epriestley mentioned this in T13072: Merge Harbormaster BuildCommand into BuildMessage.Mar 29 2018, 7:59 PM

epriestley retitled this revision from Make Harbormaster object destructible to Make Harbormaster objects destructible.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 8:01 PM

Closed by commit rP7f9a9bc800f7: Make Harbormaster objects destructible (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

5 lines

applications/

harbormaster/

storage/

HarbormasterBuildMessage.php

16 lines

HarbormasterBuildable.php

34 lines

build/

HarbormasterBuild.php

32 lines

HarbormasterBuildArtifact.php

22 lines

HarbormasterBuildTarget.php

62 lines

Diff 46126

src/__phutil_library_map__.php

Loading...

src/applications/harbormaster/storage/HarbormasterBuildMessage.php

Loading...

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

Loading...