Render directly embedded image data represented as a string in Jupyter notebooks
ClosedPublic
Actions

Authored by epriestley on Mar 26 2018, 2:23 PM.

Details

Reviewers

mydeveloperday

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rPc5b244bfd04f: Render directly embedded image data represented as a string in Jupyter notebooks

Summary

Depends on D19259. Ref T13105. Some examples represent image data as ["da", "ta"] while others represent it as "data". Accept either.

Test Plan

Rendered example notebooks with both kinds of images.

Diff Detail

Repository

rP Phabricator

Branch

doc3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19926
Build 27011: Run Core Tests
Build 27010: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 26 2018, 2:23 PM

Harbormaster completed remote builds in B19926: Diff 46106.Mar 26 2018, 2:24 PM

epriestley requested review of this revision.Mar 26 2018, 2:24 PM

mydeveloperday accepted this revision.Mar 26 2018, 2:25 PM

This revision is now accepted and ready to land.Mar 26 2018, 2:25 PM

Closed by commit rPc5b244bfd04f: Render directly embedded image data represented as a string in Jupyter notebooks (authored by epriestley). · Explain WhyMar 28 2018, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

document/

PhabricatorJupyterDocumentEngine.php

3 lines

Diff 46106

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Render directly embedded image data represented as a string in Jupyter notebooksClosedPublicActions