Paths

Table of Contentst

Differential D19259

Minor document rendering fixes: dropdown for synchronous files, URI normalization for default renderers
ClosedPublic
Actions

Authored by epriestley on Mar 26 2018, 2:20 PM.

Tags

None

Referenced Files

	F15398542: D19259.id46111.diff
	Mon, Mar 17, 12:33 AM

	F15336947: D19259.id.diff
	Sun, Mar 9, 3:36 AM

	F15284998: D19259.diff
	Tue, Mar 4, 11:16 AM

	Unknown Object (File)
	Thu, Feb 20, 1:46 AM

	Unknown Object (File)
	Tue, Feb 18, 4:29 AM

	Unknown Object (File)
	Feb 6 2025, 3:39 AM

	Unknown Object (File)
	Jan 29 2025, 11:26 PM

	Unknown Object (File)
	Jan 28 2025, 3:37 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rPb7d3101e7cbf: Minor document rendering fixes: dropdown for synchronous files, URI…

Summary

Depends on D19258. Ref T13105.

When the default renderer is an Ajax renderer, don't replace the URI. For example, when viewing a Jupyter notebook, the URI should remain /F123, not instantly change to /view/123/jupyter/.
Fix an issue where non-ajax renderers could fail to display the dropdown menu properly.

Test Plan

Viewed a Jupyter notebook, stayed on the same URI.
Changed rendering, got different URIs.
Viewed a JSON file and toggled renderers via dropdown.

Diff Detail

Repository

Branch

doc2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19925
Build 27009: Run Core Tests
Build 27008: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 26 2018, 2:20 PM

Harbormaster completed remote builds in B19925: Diff 46105.Mar 26 2018, 2:21 PM

epriestley requested review of this revision.Mar 26 2018, 2:21 PM

epriestley added a child revision: D19260: Render directly embedded image data represented as a string in Jupyter notebooks.Mar 26 2018, 2:23 PM

mydeveloperday accepted this revision.Mar 26 2018, 2:24 PM

This revision is now accepted and ready to land.Mar 26 2018, 2:24 PM

Closed by commit rPb7d3101e7cbf: Minor document rendering fixes: dropdown for synchronous files, URI… (authored by epriestley). · Explain WhyMar 28 2018, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

14 lines

webroot/

rsrc/

js/

application/

files/

behavior-document-engine.js

7 lines

Diff 46105

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/files/behavior-document-engine.js

Loading...