Differential D19258

Support logged-out access to the document rendering endpoint
ClosedPublic
Actions

Authored by epriestley on Mar 26 2018, 2:16 PM.

Details

Reviewers

mydeveloperday

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rP38999e25ac59: Support logged-out access to the document rendering endpoint

Summary

Ref T13105. Currently, logged-out users can't render documents via the endpoint even if they otherwise have access to the file.

Test Plan

Viewed a file as a logged-out user and re-rendered it via Ajax.

Diff Detail

Repository

rP Phabricator

Branch

doc1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19924
Build 27007: Run Core Tests
Build 27006: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 26 2018, 2:16 PM

Harbormaster completed remote builds in B19924: Diff 46104.Mar 26 2018, 2:17 PM

epriestley requested review of this revision.Mar 26 2018, 2:17 PM

epriestley added a child revision: D19259: Minor document rendering fixes: dropdown for synchronous files, URI normalization for default renderers.Mar 26 2018, 2:20 PM

mydeveloperday accepted this revision.Mar 26 2018, 2:25 PM

This revision is now accepted and ready to land.Mar 26 2018, 2:25 PM

Closed by commit rP38999e25ac59: Support logged-out access to the document rendering endpoint (authored by epriestley). · Explain WhyMar 28 2018, 10:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

controller/

PhabricatorFileDocumentController.php

4 lines

Diff 46104

View Options

src/applications/files/controller/PhabricatorFileDocumentController.php

Support logged-out access to the document rendering endpointClosedPublicActions