Page MenuHomePhabricator

Generate a random unique "Request ID" for SSH requests so processes can coordinate better
ClosedPublic

Authored by epriestley on Mar 22 2018, 7:56 PM.
Tags
None
Referenced Files
F19803674: D19249.diff
Mon, Mar 2, 1:14 AM
F19082501: D19249.diff
Dec 2 2025, 11:22 AM
F19082328: D19249.diff
Dec 2 2025, 10:59 AM
F19082327: D19249.diff
Dec 2 2025, 10:59 AM
F18856643: D19249.diff
Nov 1 2025, 10:50 AM
F18836932: D19249.id46088.diff
Oct 27 2025, 3:53 AM
F18836931: D19249.id46084.diff
Oct 27 2025, 3:53 AM
F18836930: D19249.id.diff
Oct 27 2025, 3:53 AM
Subscribers
None

Details

Summary

Depends on D19247. Ref T13109. When we receive an SSH request, generate a random unique ID for the request. Then thread it down through the process tree.

The immediate goal is to let the ssh-exec process coordinate with commit-hook process and log information about read and write lock wait times. Today, there's no way for ssh-exec to interact with the PushEvent, but this is the most helpful place to store this data for users.

Test Plan

Made pushes, saw the PushEvent table populate with a random request ID. Exported data and saw the ID preserved in the export.

Diff Detail

Repository
rP Phabricator
Branch
lock2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/config/option/PhabricatorAccessLogConfigOptions.php:51XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19902
Build 26976: Run Core Tests
Build 26975: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2018, 8:44 PM
This revision was automatically updated to reflect the committed changes.