Page MenuHomePhabricator

Generate a random unique "Request ID" for SSH requests so processes can coordinate better
ClosedPublic

Authored by epriestley on Mar 22 2018, 7:56 PM.
Tags
None
Referenced Files
F15450326: D19249.diff
Fri, Mar 28, 3:04 PM
F15417477: D19249.diff
Thu, Mar 20, 5:15 PM
F15414904: D19249.id46088.diff
Thu, Mar 20, 3:03 AM
F15378736: D19249.diff
Thu, Mar 13, 4:39 PM
F15376644: D19249.id46084.diff
Thu, Mar 13, 4:54 AM
F15374197: D19249.id46084.diff
Wed, Mar 12, 5:37 PM
F15332149: D19249.id46088.diff
Fri, Mar 7, 4:38 PM
Unknown Object (File)
Feb 21 2025, 3:35 PM
Subscribers
None

Details

Summary

Depends on D19247. Ref T13109. When we receive an SSH request, generate a random unique ID for the request. Then thread it down through the process tree.

The immediate goal is to let the ssh-exec process coordinate with commit-hook process and log information about read and write lock wait times. Today, there's no way for ssh-exec to interact with the PushEvent, but this is the most helpful place to store this data for users.

Test Plan

Made pushes, saw the PushEvent table populate with a random request ID. Exported data and saw the ID preserved in the export.

Diff Detail

Repository
rP Phabricator
Branch
lock2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/config/option/PhabricatorAccessLogConfigOptions.php:51XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19902
Build 26976: Run Core Tests
Build 26975: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2018, 8:44 PM
This revision was automatically updated to reflect the committed changes.