Page MenuHomePhabricator

When workflow dialog buttons are clicked, disable the button
ClosedPublic

Authored by epriestley on Mar 21 2018, 6:54 PM.
Tags
None
Referenced Files
F15458173: D19246.id46076.diff
Sun, Mar 30, 9:26 PM
F15454172: D19246.id.diff
Sat, Mar 29, 4:47 PM
F15453866: D19246.id46079.diff
Sat, Mar 29, 2:53 PM
F15445694: D19246.diff
Thu, Mar 27, 3:32 PM
F15443199: D19246.id.diff
Thu, Mar 27, 2:58 AM
F15441453: D19246.diff
Wed, Mar 26, 6:18 PM
F15423889: D19246.id46079.diff
Sat, Mar 22, 7:15 PM
F15417724: D19246.diff
Thu, Mar 20, 5:58 PM
Subscribers
None

Details

Summary

Depends on D19245. Fixes T11145. Ref T13108. See PHI488. Disable workflow buttons when they're clicked to prevent accidental client-side double submission.

This might have some weird side effects but we should normally never need to re-use a workflow dialog form so it's not immediately obvious that this can break anything.

Test Plan
  • Added sleep(1) to the Mute controller and the Maniphest task controller.
  • Added phlog(...) to the Mute controller.
  • Opened the mute dialog, mashed the button a thousand times.
    • Before: Saw a bunch of logs.
    • After: Button immediately disables, saw only one log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 6:58 PM
This revision was automatically updated to reflect the committed changes.