Page MenuHomePhabricator

When workflow dialog buttons are clicked, disable the button
ClosedPublic

Authored by epriestley on Mar 21 2018, 6:54 PM.
Tags
None
Referenced Files
F13284085: D19246.id46076.diff
Sun, Jun 2, 11:58 PM
F13276323: D19246.id.diff
Fri, May 31, 5:49 AM
F13263892: D19246.id46079.diff
Mon, May 27, 1:11 PM
F13262861: D19246.diff
Mon, May 27, 4:29 AM
F13250282: D19246.diff
Fri, May 24, 1:43 PM
F13232980: D19246.diff
Tue, May 21, 1:36 AM
F13219514: D19246.id46076.diff
Sat, May 18, 7:08 PM
F13211472: D19246.diff
Fri, May 17, 5:47 AM
Subscribers
None

Details

Summary

Depends on D19245. Fixes T11145. Ref T13108. See PHI488. Disable workflow buttons when they're clicked to prevent accidental client-side double submission.

This might have some weird side effects but we should normally never need to re-use a workflow dialog form so it's not immediately obvious that this can break anything.

Test Plan
  • Added sleep(1) to the Mute controller and the Maniphest task controller.
  • Added phlog(...) to the Mute controller.
  • Opened the mute dialog, mashed the button a thousand times.
    • Before: Saw a bunch of logs.
    • After: Button immediately disables, saw only one log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 6:58 PM
This revision was automatically updated to reflect the committed changes.