Page MenuHomePhabricator

When workflow dialog buttons are clicked, disable the button
ClosedPublic

Authored by epriestley on Mar 21 2018, 6:54 PM.
Tags
None
Referenced Files
F13219514: D19246.id46076.diff
Sat, May 18, 7:08 PM
F13211472: D19246.diff
Fri, May 17, 5:47 AM
F13196709: D19246.diff
Sun, May 12, 11:29 PM
Unknown Object (File)
Fri, May 3, 6:22 AM
Unknown Object (File)
Mon, Apr 29, 2:18 AM
Unknown Object (File)
Thu, Apr 25, 1:13 AM
Unknown Object (File)
Apr 11 2024, 9:29 AM
Unknown Object (File)
Mar 31 2024, 5:40 AM
Subscribers
None

Details

Summary

Depends on D19245. Fixes T11145. Ref T13108. See PHI488. Disable workflow buttons when they're clicked to prevent accidental client-side double submission.

This might have some weird side effects but we should normally never need to re-use a workflow dialog form so it's not immediately obvious that this can break anything.

Test Plan
  • Added sleep(1) to the Mute controller and the Maniphest task controller.
  • Added phlog(...) to the Mute controller.
  • Opened the mute dialog, mashed the button a thousand times.
    • Before: Saw a bunch of logs.
    • After: Button immediately disables, saw only one log.

Diff Detail

Repository
rP Phabricator
Branch
submit2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19894
Build 26963: Run Core Tests
Build 26962: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 6:58 PM
This revision was automatically updated to reflect the committed changes.