Page MenuHomePhabricator

When workflow dialog buttons are clicked, disable the button
ClosedPublic

Authored by epriestley on Mar 21 2018, 6:54 PM.
Tags
None
Referenced Files
F19084338: D19246.id.diff
Tue, Dec 2, 3:11 PM
F19076921: D19246.diff
Mon, Dec 1, 1:53 PM
F19056771: D19246.diff
Fri, Nov 28, 8:40 PM
F19016956: D19246.diff
Nov 23 2025, 6:08 AM
F18857369: D19246.id.diff
Nov 1 2025, 2:56 PM
F18853118: D19246.diff
Oct 31 2025, 2:16 PM
F18836924: D19246.diff
Oct 27 2025, 3:52 AM
F18807297: D19246.diff
Oct 19 2025, 12:28 AM
Subscribers
None

Details

Summary

Depends on D19245. Fixes T11145. Ref T13108. See PHI488. Disable workflow buttons when they're clicked to prevent accidental client-side double submission.

This might have some weird side effects but we should normally never need to re-use a workflow dialog form so it's not immediately obvious that this can break anything.

Test Plan
  • Added sleep(1) to the Mute controller and the Maniphest task controller.
  • Added phlog(...) to the Mute controller.
  • Opened the mute dialog, mashed the button a thousand times.
    • Before: Saw a bunch of logs.
    • After: Button immediately disables, saw only one log.

Diff Detail

Repository
rP Phabricator
Branch
submit2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19894
Build 26963: Run Core Tests
Build 26962: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 6:58 PM
This revision was automatically updated to reflect the committed changes.