Paths

Table of Contentst

Differential D19246

When workflow dialog buttons are clicked, disable the button
ClosedPublic
Actions

Authored by epriestley on Mar 21 2018, 6:54 PM.

Tags

None

Referenced Files

	F14405953: D19246.diff
	Mon, Dec 23, 9:19 AM

	Unknown Object (File)
	Sat, Dec 21, 2:51 PM

	Unknown Object (File)
	Tue, Dec 17, 6:01 AM

	Unknown Object (File)
	Tue, Dec 17, 4:29 AM

	Unknown Object (File)
	Sun, Dec 15, 4:23 PM

	Unknown Object (File)
	Sun, Dec 15, 3:04 AM

	Unknown Object (File)
	Tue, Dec 10, 8:58 PM

	Unknown Object (File)
	Thu, Nov 28, 2:36 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11145: Dialog submit buttons don't disable on click
T13108: Plans: 2018 Week 12 Bonus Content
Commits: rPc8583b016daf: When workflow dialog buttons are clicked, disable the button

Summary

Depends on D19245. Fixes T11145. Ref T13108. See PHI488. Disable workflow buttons when they're clicked to prevent accidental client-side double submission.

This might have some weird side effects but we should normally never need to re-use a workflow dialog form so it's not immediately obvious that this can break anything.

Test Plan

Added sleep(1) to the Mute controller and the Maniphest task controller.
Added phlog(...) to the Mute controller.
Opened the mute dialog, mashed the button a thousand times.
- Before: Saw a bunch of logs.
- After: Button immediately disables, saw only one log.

Diff Detail

Repository

Branch

submit2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19894
Build 26963: Run Core Tests
Build 26962: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 21 2018, 6:54 PM

Harbormaster completed remote builds in B19894: Diff 46076.Mar 21 2018, 6:56 PM

epriestley requested review of this revision.Mar 21 2018, 6:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 6:58 PM

Closed by commit rPc8583b016daf: When workflow dialog buttons are clicked, disable the button (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

28 lines

webroot/

rsrc/

externals/

javelin/

lib/

4 lines

Diff 46076

resources/celerity/map.php

Loading...

webroot/rsrc/externals/javelin/lib/Workflow.js

Loading...