Page MenuHomePhabricator
Differential D19238

Add an async driver for document rendering and a crude "Hexdump" document engine
ClosedPublic
Actions

Authored by epriestley on Mar 19 2018, 5:59 PM.
Tags
None
Referenced Files
F13133391: D19238.diff
Wed, May 1, 9:47 PM
Unknown Object (File)
Mon, Apr 29, 6:00 PM
Unknown Object (File)
Sun, Apr 28, 1:08 AM
Unknown Object (File)
Thu, Apr 25, 1:27 AM
Unknown Object (File)
Tue, Apr 23, 11:20 AM
Unknown Object (File)
Fri, Apr 19, 7:34 PM
Unknown Object (File)
Tue, Apr 16, 4:53 PM
Unknown Object (File)
Thu, Apr 11, 8:11 AM
View All 100 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rPf646153f4dbe: Add an async driver for document rendering and a crude "Hexdump" document engine
Summary

Depends on D19237. Ref T13105. This adds a (very basic) "Hexdump" engine (mostly just to have a second option to switch to) and a selector for choosing view modes.

Test Plan

Viewed some files, switched between audio/video/image/hexdump.

Diff Detail

Repository
rP Phabricator
Branch
doc2
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/files/behavior-document-engine.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 19881
Build 26944: Run Core Tests
Build 26943: arc lint + arc unit

Revision Contents
Changeset List

Diff 46062

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDocumentController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/document/PhabricatorAudioDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentRef.php

Loading...
View Options

src/applications/files/document/PhabricatorHexdumpDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorImageDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorVideoDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorVoidDocumentEngine.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
View Options

webroot/rsrc/js/application/files/behavior-document-engine.js

Loading...
Phabricator · Built by Phacility